Skip to content

#345 - mutations are optional and errors should come back if they are missing - #349

Merged
bbakerman merged 3 commits into
graphql-java:masterfrom
bbakerman:345-npe-on-missing-mutation
Mar 31, 2017
Merged

bbakerman merged 3 commits into
graphql-java:masterfrom
bbakerman:345-npe-on-missing-mutation

Conversation

@bbakerman

Copy link
Copy Markdown
Member

#345 outlined that NPEs can happen when mutation strategies are missing

But in fixing that I noticed that we blow up when there is no mutation root type

This is actually valid to NOT have a mutation root type but the spec is unclear on what should happen when "mutation is not allowed".

I am pretty sure that NullPointerException is not the desired response ;)

So I have made it return a new MutationNotSupportedError instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant