Skip to content

Revert "A test to show that validation rules do not catch a mutation query to schema mismatch" #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dondonz merged 1 commit into from
Oct 24, 2023
Merged

Revert "A test to show that validation rules do not catch a mutation query to schema mismatch" #3360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions src/test/groovy/graphql/ParseAndValidateTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
package graphql

import graphql.language.Document
import graphql.parser.InvalidSyntaxException
import graphql.parser.Parser
import graphql.schema.GraphQLSchema
import graphql.schema.idl.SchemaParser
import graphql.schema.idl.TypeDefinitionRegistry
import graphql.schema.idl.UnExecutableSchemaGenerator
import graphql.validation.ValidationError
import graphql.validation.ValidationErrorType
import graphql.validation.rules.NoUnusedFragments
Expand Down Expand Up @@ -161,30 +155,4 @@ class ParseAndValidateTest extends Specification {
then:
!rs.errors.isEmpty() // all rules apply - we have errors
}

def "issue 2740 - evidence of not working"() {
def sdl = '''
type Query {
myquery : String!
}
'''

def registry = new SchemaParser().parse(sdl)
def schema = UnExecutableSchemaGenerator.makeUnExecutableSchema(registry)
def graphQL = GraphQL.newGraphQL(schema).build()

String request = "mutation MyMutation { mymutation }"

when:
def er = graphQL.execute(request)
then:
er.errors.size() == 1

when:
Document inputDocument = new Parser().parseDocument(request)
List<ValidationError> errors = ParseAndValidate.validate(schema, inputDocument)

then:
errors.size() == 1
}
}