Issue 3332 - overlapping aliases should be prevented #3334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Sep 21, 2023
| errorCollector.getErrors().size() == 1 | ||
| errorCollector.getErrors()[0].message == "Validation error (FieldsConflict@[cat]) : 'name' : 'foo1' and 'foo2' are different fields" | ||
| errorCollector.getErrors()[0].locations == [new SourceLocation(3, 13), new SourceLocation(4, 13)] | ||
| } |
bbakerman
commented
Sep 21, 2023
| then: | ||
| errorCollector.getErrors().size() == 1 | ||
| errorCollector.getErrors()[0].message == "Validation error (FieldsConflict@[dog]) : 'name' : 'nickname' and 'name' are different fields" | ||
| errorCollector.getErrors()[0].locations == [new SourceLocation(3, 13), new SourceLocation(4, 13)] |
Member
Author
There was a problem hiding this comment.
This does NOT fail ; wat ??
Member
Author
There was a problem hiding this comment.
dog parent field was nullable
bbakerman
added
the
needs to be backported
bbakerman
commented
Sep 21, 2023
| fieldType = fieldDefinition != null ? fieldDefinition.getType() : null; | ||
| } | ||
| fieldMap.get(responseName).add(new FieldAndType(field, fieldType, parentType)); | ||
| fieldMap.get(responseName).add(new FieldAndType(field, fieldType, unwrappedParent)); |
Member
Author
There was a problem hiding this comment.
this is the bug. When the parent type is a non null (or list) wrapped type - it was not being held in the field+ parent type construct as that BUT it was being compared as if it was a fully unwrapped type
dondonz
approved these changes
Oct 15, 2023
dondonz
added a commit
that referenced
this pull request
Oct 22, 2023
dondonz
added a commit
that referenced
this pull request
Oct 22, 2023
dondonz
deleted the
issue-3332-overlapping-fields-aliaes-should-be-prevented
branch
bbakerman
pushed a commit
that referenced
this pull request
Oct 23, 2023
bbakerman
pushed a commit
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows the problem as reported in #3332 as happening
However I have another test that works and logically I cant see the difference.
Anyway here is a reproduction we can work on