Experimental - oneOf directive support #3275
Conversation
…ctive ends up affecting
…now in resolver - untested
…now in valueresolver - with tests from spec
| true, | ||
| false, | ||
| true, | ||
| true, |
There was a problem hiding this comment.
on by default in new versions
There was a problem hiding this comment.
but some one could turn it off if need be
…now in valueresolver - PR tweaks
…end to end test
| public static VariableReference of(String name) { | ||
| return newVariableReference().name(name).build(); | ||
| } | ||
|
|
There was a problem hiding this comment.
just a better helper to make one - like StringValue.of()
| ]) | CoercedVariables.of([var: "abc"]) | [arg: [a: "abc"]] | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
most of the tests are here - these are taken from the examples given in the spec update plus some they missed
| er.errors[0].message == "Exception while fetching data (/f) : OneOf type field 'OneOf.a' must be non-null." | ||
|
|
||
| // lots more covered in unit tests | ||
| } |
There was a problem hiding this comment.
some end 2 end testing behind the unit tested we have for ValueResolver
| throw new OneOfNullValueException(msg); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
remember we can have a mix of input - literals and maps and invalid input might be a with a variable with no map entries or multiple.
The unit tests for this explore these different conditions
| } | ||
| // eventually GraphQLDirective as applied directive goes away | ||
| return directives.stream().anyMatch(d -> Directives.OneOfDirective.getName().equals(d.getName())); | ||
| } |
There was a problem hiding this comment.
The boolean is calculated on creation and hence fast from that time forward
| } | ||
| if (additionalDirectives.stream().noneMatch(d -> d.getName().equals(Directives.OneOfDirective.getName()))) { | ||
| additionalDirectives.add(Directives.OneOfDirective); | ||
| } |
There was a problem hiding this comment.
always available like deprecated and specifiedby
bbakerman
changed the title
# Conflicts: # src/test/groovy/graphql/introspection/IntrospectionTest.groovy
This PR provides
@oneOfsupport to graphql-javarelated to #3266
This is now complete.
The error messages here are inspired by the graphql-js versions.
I chose to add
isOneOfinto our pre built Introspection queries by default and have an option to turn it off if it causes problems (I dont see how it would be just in case)I am a fan of the directive based approach of this mechanism
This code is considered experimental namely because the spec has not been accepted. The PR has been put into the reference implementation graphql-js however so its not pie in the sky stuff