Skip to content

Upgrade v18 to patched version of Guava - #3243

Merged
dondonz merged 1 commit into
18.xfrom
guava-patch-for-18.x
Jun 8, 2023
Merged

dondonz merged 1 commit into
18.xfrom
guava-patch-for-18.x

Conversation

@dondonz

@dondonz dondonz commented Jun 7, 2023 •

Copy link
Copy Markdown
Member

This PR will update the version of Guava to a patched version (32.0.0) so that security scanners do not mistakenly flag graphql-java as vulnerable. graphql-java never used the affected classes, this PR is only to make your security scanner happy.

In graphql-java we shade selected classes from Guava. We don't actually use the affected classes in CVE-2023-2976, so this library was never vulnerable to CVE-2023-2976. However, in #3239 we received reports that security scanners have mistakenly flagged graphql-java as vulnerable because we do still include the Guava POM inside the META-INF directory of our jar. We still want to include the Guava POM in the jar, as a record of the version we shaded classes from.

Further explanation of exploit: GHSA-5mg8-w23w-74h3

@dondonz
dondonz merged commit 6a6e48f into 18.x Jun 8, 2023
@dondonz
dondonz deleted the guava-patch-for-18.x branch June 8, 2023 00:29
@dondonz dondonz added this to the 18.6 milestone Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants