Backported the fix to remove sun.misc #3099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and make sure MANIFEST.MF is the first entry in the JAR file
Member
|
Hello, thanks for the PR. As a heads up, we haven't yet decided what will be backported or if we will do another v19 release. We typically backport critical security fixes and we decide other fixes on a case by case basis. I will take this PR into consideration at the next release point. |
Contributor
Author
|
Right now we (Sling) is having a problem that we cannot use graphql-java out of the box on any versions with the security fix in 17.4 to 20.0 because of that. In addition master has the issue with class loading that prevents us from using 20.x. |
Member
|
To follow up, we will include the fix for the class loading problem #3095 in the next release. Hopefully you'll be able to use 20.1 when it's released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and make sure MANIFEST.MF is the first entry in the JAR file.
Due to a class loading issue in 20.0 I am going to upgrade to 19.x in Sling Graphql Core and so I back ported the issues fixed in master.