Repository navigation
Fix #296: Introspection on default value for input object is not following GraphQL spec - #297
Closed
dminkovsky wants to merge 1 commit into
Closed
dminkovsky wants to merge 1 commit into
dminkovsky wants to merge 1 commit into
Conversation
dminkovsky
commented
Jan 12, 2017
|
|
||
| def "test"() { | ||
|
|
||
| def graphql = GraphQL.newGraphQL(newSchema() |
Contributor
Author
There was a problem hiding this comment.
Use TestUtil.schemaWithInputType(inputType)
|
This unit test checks the exact reported issue. Thanks. To make unit test for default value more complete, we should include testing with other value types as well, including list and enum etc. |
Contributor
Author
|
Yes definitely.
чт, 12 янв. 2017 г. в 20:50, rayngwf <notifications@github.com>:
… This unit test checks the exact reported issue. Thanks.
To make unit test for default value more complete, we should include
testing with other value types as well, including list and enum etc.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#297 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANWZbgJA6FOzpKc8TCethjNg3pe7x66ks5rRthygaJpZM4Lh5s9>
.
|
Member
|
This PR fixes this issue and adds a shed load more functionality at the same time |
Member
|
This is no longer needed as is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant lines:
graphql-java/src/main/java/graphql/introspection/Introspection.java
Lines 84 to 89 in 6b94b45
I think this will require #126