Cherry pick raw and coerced variable refactor for 18.x branch #2861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
approved these changes
Jun 19, 2022
| private final Object localContext; | ||
| private final Object root; | ||
| private final Map<String, Object> variables; | ||
| private final RawVariables rawVariables; |
Member
There was a problem hiding this comment.
Depending how aggressive you are in "sem ver" one could argue this is not a bug fix dues to the new API constructs. But since its backwards compat in all the places. Cool
Member
Author
There was a problem hiding this comment.
That's a good point. This bugfix is tricky because it depended on the variables refactor. I figured it would be easier to cherry pick the refactor as well, rather than try crowbar the bugfix in alone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks the raw and coerced variable refactor changes in #2802, master commit
86d54438Why is the base branch 18.x?
We'll be releasing a few bugfixes from this branch, to allow users to choose between bugfixes only or all master changes (to be released as v19). We're using the pull request format to keep track of changes