Skip to content

Make some inner classes static #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bbakerman merged 1 commit into from
Apr 26, 2022
Merged

Make some inner classes static #2804

bbakerman merged 1 commit into from
Apr 26, 2022
+3 −3

Conversation

@kilink
Copy link
Contributor

@kilink kilink commented Apr 18, 2022

There were a few instances where inner classes were used unnecessarily over
static inner classes.

@kilink
Make some inner classes static
28b2288 
There were a few instances where inner classes were used unnecessarily over
static inner classes.
bbakerman
bbakerman approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bbakerman bbakerman added this to the 19.0 milestone Apr 26, 2022
@bbakerman bbakerman merged commit a9a8a29 into graphql-java:master Apr 26, 2022
@dondonz dondonz modified the milestones: 19.0, 18.1 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbakerman bbakerman bbakerman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.1

Development

Successfully merging this pull request may close these issues.

3 participants

@kilink @bbakerman @dondonz