Skip to content

Fix instances of incorrectly sized Maps and Sets #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
Apr 17, 2022
+5 −4
Merged

Fix instances of incorrectly sized Maps and Sets #2798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/graphql/execution/instrumentation/ChainedInstrumentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package graphql.execution.instrumentation;

import com.google.common.collect.ImmutableList;
import com.google.common.collect.Maps;
import graphql.ExecutionInput;
import graphql.ExecutionResult;
import graphql.PublicApi;
Expand Down Expand Up @@ -210,7 +211,7 @@ private static class ChainedInstrumentationState implements InstrumentationState


private ChainedInstrumentationState(List<Instrumentation> instrumentations, InstrumentationCreateStateParameters parameters) {
instrumentationStates = new LinkedHashMap<>(instrumentations.size());
instrumentationStates = Maps.newLinkedHashMapWithExpectedSize(instrumentations.size());
instrumentations.forEach(i -> instrumentationStates.put(i, i.createState(parameters)));
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/graphql/validation/rules/UniqueArgumentNamesRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package graphql.validation.rules;

import com.google.common.collect.Sets;
import graphql.Internal;
import graphql.language.Argument;
import graphql.language.Directive;
Expand All @@ -10,7 +11,6 @@
import graphql.validation.ValidationErrorCollector;
import graphql.validation.ValidationErrorType;

import java.util.HashSet;
import java.util.List;
import java.util.Set;

Expand All @@ -31,7 +31,7 @@ public void checkField(Field field) {
return;
}

Set<String> arguments = new HashSet<>();
Set<String> arguments = Sets.newHashSetWithExpectedSize(field.getArguments().size());

for (Argument argument : field.getArguments()) {
if (arguments.contains(argument.getName())) {
Expand All @@ -48,7 +48,7 @@ public void checkDirective(Directive directive, List<Node> ancestors) {
return;
}

Set<String> arguments = new HashSet<>(directive.getArguments().size());
Set<String> arguments = Sets.newHashSetWithExpectedSize(directive.getArguments().size());

for (Argument argument : directive.getArguments()) {
if (arguments.contains(argument.getName())) {
Expand Down