Skip to content

Make public static fields immutable in DirectiveInfo #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
Apr 3, 2022
Merged

Make public static fields immutable in DirectiveInfo #2781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions src/main/java/graphql/schema/idl/DirectiveInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package graphql.schema.idl;

import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import graphql.Directives;
import graphql.PublicApi;
import graphql.schema.GraphQLDirective;

import java.util.LinkedHashMap;
import java.util.LinkedHashSet;
import java.util.Map;
import java.util.Set;

Expand All @@ -18,27 +18,20 @@ public class DirectiveInfo {
/**
* A set of directives which provided by graphql specification
*/
public static final Set<GraphQLDirective> GRAPHQL_SPECIFICATION_DIRECTIVES = new LinkedHashSet<>();
public static final Set<GraphQLDirective> GRAPHQL_SPECIFICATION_DIRECTIVES = ImmutableSet.of(
Directives.IncludeDirective,
Directives.SkipDirective,
Directives.DeprecatedDirective,
Directives.SpecifiedByDirective);

/**
* A map from directive name to directive which provided by specification
*/
public static final Map<String, GraphQLDirective> GRAPHQL_SPECIFICATION_DIRECTIVE_MAP = new LinkedHashMap<>();

static {
GRAPHQL_SPECIFICATION_DIRECTIVES.add(Directives.IncludeDirective);
GRAPHQL_SPECIFICATION_DIRECTIVES.add(Directives.SkipDirective);
GRAPHQL_SPECIFICATION_DIRECTIVES.add(Directives.DeprecatedDirective);
GRAPHQL_SPECIFICATION_DIRECTIVES.add(Directives.SpecifiedByDirective);
}

static {
GRAPHQL_SPECIFICATION_DIRECTIVE_MAP.put(Directives.IncludeDirective.getName(), Directives.IncludeDirective);
GRAPHQL_SPECIFICATION_DIRECTIVE_MAP.put(Directives.SkipDirective.getName(), Directives.SkipDirective);
GRAPHQL_SPECIFICATION_DIRECTIVE_MAP.put(Directives.DeprecatedDirective.getName(), Directives.DeprecatedDirective);
GRAPHQL_SPECIFICATION_DIRECTIVE_MAP.put(Directives.SpecifiedByDirective.getName(), Directives.SpecifiedByDirective);
}

public static final Map<String, GraphQLDirective> GRAPHQL_SPECIFICATION_DIRECTIVE_MAP = ImmutableMap.of(
Directives.IncludeDirective.getName(), Directives.IncludeDirective,
Directives.SkipDirective.getName(), Directives.SkipDirective,
Directives.DeprecatedDirective.getName(), Directives.DeprecatedDirective,
Directives.SpecifiedByDirective.getName(), Directives.SpecifiedByDirective);

/**
* Returns true if a directive with provided directiveName has been defined in graphql specification
Expand Down