Skip to content

Fixing the missing description for enum values for introspection to schema conversion #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
Apr 3, 2022
Merged

Fixing the missing description for enum values for introspection to schema conversion #2778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/graphql/introspection/IntrospectionResultToSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ EnumTypeDefinition createEnum(Map<String, Object> input) {
for (Map<String, Object> enumValue : enumValues) {

EnumValueDefinition.Builder enumValueDefinition = EnumValueDefinition.newEnumValueDefinition().name((String) enumValue.get("name"));
enumTypeDefinition.description(toDescription(input));
enumValueDefinition.description(toDescription(enumValue));
Copy link
Member

@bbakerman bbakerman Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch


createDeprecatedDirective(enumValue, enumValueDefinition);

Expand Down
9 changes: 9 additions & 0 deletions src/test/groovy/graphql/introspection/IntrospectionResultToSchemaTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,11 @@ interface Character {
then:
result == """"One of the films in the Star Wars Trilogy"
enum Episode {
"Released in 1977."
NEWHOPE
"Released in 1980."
EMPIRE
"Released in 1983."
JEDI @deprecated(reason: "killed by clones")
}"""

Expand Down Expand Up @@ -425,8 +428,11 @@ interface Character {

"One of the films in the Star Wars Trilogy"
enum Episode {
"Released in 1977."
NEWHOPE
"Released in 1980."
EMPIRE
"Released in 1983."
JEDI
}

Expand Down Expand Up @@ -492,14 +498,17 @@ type Episode {

" Simpson seasons"
enum Season {
" the beginning"
Season1
Season2
Season3
Season4
" Another one"
Season5
Season6
Season7
Season8
" Not really the last one :-)"
Season9
}

Expand Down