Make ExecutionStepInfo values be lazy #2749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will improve memory usage if you don't use the ESI arguments, and it will reduce CPU usage somewhat in heavy systems by doing less work (albeit it a small amount)
bbakerman
commented
Feb 28, 2022
|
|
||
| private final Object object; | ||
| private final ImmutableMapWithNullValues<String, Object> arguments; | ||
| private final Supplier<ImmutableMapWithNullValues<String, Object>> arguments; |
Member
Author
There was a problem hiding this comment.
This is a viral change - type resolving wont materialise the ESI arguments unless it has to
bbakerman
commented
Feb 28, 2022
| this.parent = builder.parentInfo; | ||
| this.type = assertNotNull(builder.type, () -> "you must provide a graphql type"); | ||
| this.arguments = builder.arguments; | ||
| this.fieldContainer = builder.fieldContainer; |
Member
Author
There was a problem hiding this comment.
move to builder as arg - modernisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve memory usage if you don't use the ESI arguments, and it will reduce CPU usage somewhat in heavy systems by doing less work (albeit by a small amount)
If a DFE or other code does not ask for the arguments - then no value resolving will happen for them.