Skip to content

Avoid a binary incompatible change while retaining common code #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 2 commits into from
Feb 28, 2022
Merged

Avoid a binary incompatible change while retaining common code #2748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
491f4a0
Avoid a binary incompatible change while retaining common code
bbakerman Feb 28, 2022
3d51e13
removed applied methods which are new
bbakerman Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/main/java/graphql/schema/GraphQLArgument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,42 @@ public Builder clearValue() {
return this;
}

// -- the following are repeated to avoid a binary incompatibility problem --
@Override
public Builder replaceDirectives(List<GraphQLDirective> directives) {
return super.replaceDirectives(directives);
}

@Override
public Builder withDirectives(GraphQLDirective... directives) {
return super.withDirectives(directives);
}

@Override
public Builder withDirective(GraphQLDirective directive) {
return super.withDirective(directive);
}

@Override
public Builder withDirective(GraphQLDirective.Builder builder) {
return super.withDirective(builder);
}

@Override
public Builder clearDirectives() {
return super.clearDirectives();
}

@Override
public Builder name(String name) {
return super.name(name);
}

@Override
public Builder description(String description) {
return super.description(description);
}

public GraphQLArgument build() {
assertNotNull(type, () -> "type can't be null");

Expand Down
12 changes: 12 additions & 0 deletions src/main/java/graphql/schema/GraphQLDirective.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,18 @@ public Builder definition(DirectiveDefinition definition) {
return this;
}

// -- the following are repeated to avoid a binary incompatibility problem --

@Override
public Builder name(String name) {
return super.name(name);
}

@Override
public Builder description(String description) {
return super.description(description);
}

public GraphQLDirective build() {
return new GraphQLDirective(
name,
Expand Down
36 changes: 36 additions & 0 deletions src/main/java/graphql/schema/GraphQLEnumType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,42 @@ public Builder clearValues() {
return this;
}

// -- the following are repeated to avoid a binary incompatibility problem --

@Override
public Builder replaceDirectives(List<GraphQLDirective> directives) {
return super.replaceDirectives(directives);
}

@Override
public Builder withDirectives(GraphQLDirective... directives) {
return super.withDirectives(directives);
}

@Override
public Builder withDirective(GraphQLDirective directive) {
return super.withDirective(directive);
}

@Override
public Builder withDirective(GraphQLDirective.Builder builder) {
return super.withDirective(builder);
}

@Override
public Builder clearDirectives() {
return super.clearDirectives();
}

@Override
public Builder name(String name) {
return super.name(name);
}

@Override
public Builder description(String description) {
return super.description(description);
}

public GraphQLEnumType build() {
return new GraphQLEnumType(
Expand Down
37 changes: 37 additions & 0 deletions src/main/java/graphql/schema/GraphQLEnumValueDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,43 @@ public Builder definition(EnumValueDefinition definition) {
return this;
}

// -- the following are repeated to avoid a binary incompatibility problem --

@Override
public Builder replaceDirectives(List<GraphQLDirective> directives) {
return super.replaceDirectives(directives);
}

@Override
public Builder withDirectives(GraphQLDirective... directives) {
return super.withDirectives(directives);
}

@Override
public Builder withDirective(GraphQLDirective directive) {
return super.withDirective(directive);
}

@Override
public Builder withDirective(GraphQLDirective.Builder builder) {
return super.withDirective(builder);
}

@Override
public Builder clearDirectives() {
return super.clearDirectives();
}

@Override
public Builder name(String name) {
return super.name(name);
}

@Override
public Builder description(String description) {
return super.description(description);
}

public GraphQLEnumValueDefinition build() {
return new GraphQLEnumValueDefinition(name,
description,
Expand Down
37 changes: 37 additions & 0 deletions src/main/java/graphql/schema/GraphQLFieldDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,43 @@ public Builder deprecate(String deprecationReason) {
return this;
}

// -- the following are repeated to avoid a binary incompatibility problem --

@Override
public Builder replaceDirectives(List<GraphQLDirective> directives) {
return super.replaceDirectives(directives);
}

@Override
public Builder withDirectives(GraphQLDirective... directives) {
return super.withDirectives(directives);
}

@Override
public Builder withDirective(GraphQLDirective directive) {
return super.withDirective(directive);
}

@Override
public Builder withDirective(GraphQLDirective.Builder builder) {
return super.withDirective(builder);
}

@Override
public Builder clearDirectives() {
return super.clearDirectives();
}

@Override
public Builder name(String name) {
return super.name(name);
}

@Override
public Builder description(String description) {
return super.description(description);
}

public GraphQLFieldDefinition build() {
return new GraphQLFieldDefinition(
name,
Expand Down
37 changes: 37 additions & 0 deletions src/main/java/graphql/schema/GraphQLInputObjectField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,43 @@ public Builder clearDefaultValue() {
return this;
}

// -- the following are repeated to avoid a binary incompatibility problem --

@Override
public Builder replaceDirectives(List<GraphQLDirective> directives) {
return super.replaceDirectives(directives);
}

@Override
public Builder withDirectives(GraphQLDirective... directives) {
return super.withDirectives(directives);
}

@Override
public Builder withDirective(GraphQLDirective directive) {
return super.withDirective(directive);
}

@Override
public Builder withDirective(GraphQLDirective.Builder builder) {
return super.withDirective(builder);
}

@Override
public Builder clearDirectives() {
return super.clearDirectives();
}

@Override
public Builder name(String name) {
return super.name(name);
}

@Override
public Builder description(String description) {
return super.description(description);
}

public GraphQLInputObjectField build() {
assertNotNull(type, () -> "type can't be null");
return new GraphQLInputObjectField(
Expand Down
37 changes: 37 additions & 0 deletions src/main/java/graphql/schema/GraphQLInputObjectType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,43 @@ public Builder clearFields() {
return this;
}

// -- the following are repeated to avoid a binary incompatibility problem --

@Override
public Builder replaceDirectives(List<GraphQLDirective> directives) {
return super.replaceDirectives(directives);
}

@Override
public Builder withDirectives(GraphQLDirective... directives) {
return super.withDirectives(directives);
}

@Override
public Builder withDirective(GraphQLDirective directive) {
return super.withDirective(directive);
}

@Override
public Builder withDirective(GraphQLDirective.Builder builder) {
return super.withDirective(builder);
}

@Override
public Builder clearDirectives() {
return super.clearDirectives();
}

@Override
public Builder name(String name) {
return super.name(name);
}

@Override
public Builder description(String description) {
return super.description(description);
}

public GraphQLInputObjectType build() {
return new GraphQLInputObjectType(
name,
Expand Down
38 changes: 38 additions & 0 deletions src/main/java/graphql/schema/GraphQLInterfaceType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,44 @@ public Builder withInterfaces(GraphQLTypeReference... references) {
return this;
}

// -- the following are repeated to avoid a binary incompatibility problem --


@Override
public Builder replaceDirectives(List<GraphQLDirective> directives) {
return super.replaceDirectives(directives);
}

@Override
public Builder withDirectives(GraphQLDirective... directives) {
return super.withDirectives(directives);
}

@Override
public Builder withDirective(GraphQLDirective directive) {
return super.withDirective(directive);
}

@Override
public Builder withDirective(GraphQLDirective.Builder builder) {
return super.withDirective(builder);
}

@Override
public Builder clearDirectives() {
return super.clearDirectives();
}

@Override
public Builder name(String name) {
return super.name(name);
}

@Override
public Builder description(String description) {
return super.description(description);
}

public GraphQLInterfaceType build() {
return new GraphQLInterfaceType(
name,
Expand Down
37 changes: 37 additions & 0 deletions src/main/java/graphql/schema/GraphQLObjectType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,43 @@ public Builder clearInterfaces() {
return this;
}

// -- the following are repeated to avoid a binary incompatibility problem --

@Override
public Builder replaceDirectives(List<GraphQLDirective> directives) {
return super.replaceDirectives(directives);
}

@Override
public Builder withDirectives(GraphQLDirective... directives) {
return super.withDirectives(directives);
}

@Override
public Builder withDirective(GraphQLDirective directive) {
return super.withDirective(directive);
}

@Override
public Builder withDirective(GraphQLDirective.Builder builder) {
return super.withDirective(builder);
}

@Override
public Builder clearDirectives() {
return super.clearDirectives();
}

@Override
public Builder name(String name) {
return super.name(name);
}

@Override
public Builder description(String description) {
return super.description(description);
}

public GraphQLObjectType build() {
return new GraphQLObjectType(
name,
Expand Down
Loading