Rework isConditional to work without parent type name and adopt DataFetchingSelectionSet to ENF changes #2738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andimarek
changed the title
andimarek
changed the title
gnawf
reviewed
Feb 28, 2022
Contributor
gnawf
left a comment
gnawf
left a comment
There was a problem hiding this comment.
Needs unwrapAll around union handling, but otherwise good.
src/main/java/graphql/normalized/ExecutableNormalizedField.java
Outdated
Show resolved
Hide resolved
src/main/java/graphql/normalized/ExecutableNormalizedField.java
Outdated
Show resolved
Hide resolved
src/main/java/graphql/normalized/ExecutableNormalizedField.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Franklin Wang <9077461+gnawf@users.noreply.github.com>
Co-authored-by: Franklin Wang <9077461+gnawf@users.noreply.github.com>
Co-authored-by: Franklin Wang <9077461+gnawf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes a test for the DFSelectionSet for covariance fields.
It also fixes a bug for ENF where __typename in Unions were not merged.