Adds a predicate mechanism to compile a document into all variables or just some #2731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r just some This moves the Nadel fixes back in graphql-java world
bbakerman
commented
Feb 22, 2022
|
|
||
| private static String getVarName(int variableOrdinal) { | ||
| return "v" + variableOrdinal; | ||
| } |
Member
Author
There was a problem hiding this comment.
I shortened the original work that Artyom put in as var_0 - I figure we should be as short as possible
gnawf
reviewed
Feb 22, 2022
Contributor
gnawf
left a comment
gnawf
left a comment
There was a problem hiding this comment.
Shit I never pressed submit yesterday
| * @return the map of variable names to variable values | ||
| */ | ||
| public Map<String, Object> getVariablesMap() { | ||
| return valueWithDefinitions.stream() |
Contributor
There was a problem hiding this comment.
No immutable collections stuff?
| * The {@link ExecutableNormalizedOperationToAstCompiler} then uses all the variables when it compiles the final document. | ||
| */ | ||
| @Internal | ||
| public class VariableAccumulator { |
| /** | ||
| * This predicate indicates whether a variable should be made for this field argument | ||
| */ | ||
| @Internal |
| @@ -0,0 +1,19 @@ | |||
| package graphql.schema.scalars; | |||
Contributor
There was a problem hiding this comment.
Shouldn't this be under the test module?
| @@ -0,0 +1,177 @@ | |||
| package graphql.schema.scalars; | |||
| // some values can be null (NullValue) and hence we can use Immutable Lists | ||
| return arrayValues.stream() | ||
| .map(ValueToVariableValueCompiler::toVariableValue) | ||
| .collect(toList()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the Nadel fixes back in graphql-java world