Skip to content

Support custom schema validation error classification - #2723

Merged
bbakerman merged 1 commit into
graphql-java:masterfrom
dugenkui03:supportCustomSchemaValidationError
Feb 12, 2022
Merged

bbakerman merged 1 commit into
graphql-java:masterfrom
dugenkui03:supportCustomSchemaValidationError

Conversation

@dugenkui03

Copy link
Copy Markdown
Contributor

No description provided.


@Internal
public enum SchemaValidationErrorType {
public enum SchemaValidationErrorType implements SchemaValidationErrorClassification{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah enums are a mistake in an API - albeit this is not actually API yet but rather @internal

Either way enums lock you into a close type system and that is bad for errors since we can always invent new errors and error types

@bbakerman

Copy link
Copy Markdown
Member

While I like this code better than before and it's more extendable - the code involved is still @Internal so use at your own risk

@bbakerman bbakerman added this to the 18.0 milestone Feb 12, 2022
@bbakerman
bbakerman merged commit 52e876d into graphql-java:master Feb 12, 2022
@dugenkui03

Copy link
Copy Markdown
Contributor Author

Thanks for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants