Support custom schema validation error classification #2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
reviewed
Feb 12, 2022
|
|
||
| @Internal | ||
| public enum SchemaValidationErrorType { | ||
| public enum SchemaValidationErrorType implements SchemaValidationErrorClassification{ |
Member
There was a problem hiding this comment.
yeah enums are a mistake in an API - albeit this is not actually API yet but rather @internal
Either way enums lock you into a close type system and that is bad for errors since we can always invent new errors and error types
bbakerman
approved these changes
Feb 12, 2022
Member
|
While I like this code better than before and it's more extendable - the code involved is still |
Contributor
Author
|
Thanks for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.