Skip to content

Replace wrong constructor call to BigInteger in tests - #2711

Merged
bbakerman merged 1 commit into
graphql-java:masterfrom
jord1e:fix-scalar-int-float-tests
Feb 3, 2022
Merged

bbakerman merged 1 commit into
graphql-java:masterfrom
jord1e:fix-scalar-int-float-tests

Conversation

@jord1e

@jord1e jord1e commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

ScalarFloatTest and ScalarIntTest used the wrong constructor. This caused failing tests when compiling past JDK 8.

Also adds a ScalarFloatTest testcase for new BigDecimal("4.2") -> 4.2d

Part of my CI effort (#2676 )

ScalarFloatTest and ScalarIntTest used the wrong constructor. This caused failing tests when compiling past JDK 8.

Also adds a ScalarFloatTest testcase for `new BigDecimal("4.2") -> 4.2d`
@bbakerman bbakerman added this to the 18.0 milestone Feb 3, 2022
@bbakerman
bbakerman merged commit 3ca5783 into graphql-java:master Feb 3, 2022
@bbakerman

Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants