Skip to content

This uses -parameters as javac options #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
Jan 26, 2022
Merged

This uses -parameters as javac options #2671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,10 @@ task testng(type: Test) {
}
check.dependsOn testng

compileJava.source file("build/generated-src"), sourceSets.main.java
compileJava {
options.compilerArgs += ["-parameters"]
source file("build/generated-src"), sourceSets.main.java
}

generateGrammarSource {
includes = ['Graphql.g4']
Expand Down
17 changes: 17 additions & 0 deletions src/test/groovy/graphql/JvmSpecificTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package graphql

import spock.lang.Specification

import java.lang.reflect.Method

class JvmSpecificTest extends Specification {

def "javac -parameters is in place"() {
when:
Method method = ExecutionInput.class.getDeclaredMethods().toList().find {it.name == "transform"}
def parameters = method.getParameters()
then:
parameters.length == 1
parameters[0].name == "builderConsumer" // without -parameters this would be "arg0"
}
}