Allows nullable error attributes in GraphqlErrorBuilder #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andimarek
requested changes
Jan 24, 2022
Member
andimarek
left a comment
andimarek
left a comment
There was a problem hiding this comment.
I think we should use the Nullable annotation to communicate this more clearly
|
|
||
| public GraphqlErrorBuilder locations(List<SourceLocation> locations) { | ||
| this.locations.addAll(assertNotNull(locations)); | ||
| if (locations != null) { |
Member
There was a problem hiding this comment.
can we add the Nullable annotation to the argument to make this more clear?
Member
There was a problem hiding this comment.
@bbakerman I think that is a missunderstanding: the result is never null, but the argument. So the directive should be on the argument.
# Conflicts: # src/main/java/graphql/GraphqlErrorBuilder.java
andimarek
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2637