Bugfix: Check wiring factory when fetching scalar implementations in ArgValueOfAllowedTypeChecker #2648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alar() where it wouldn't check the wiring factory first for scalar implementations
bbakerman
approved these changes
Dec 20, 2021
Member
bbakerman
left a comment
bbakerman
left a comment
There was a problem hiding this comment.
Ideally we would also have a test showing the wiring factory getting called
…llowedScalar() checks for a wiring factory
Contributor
Author
|
@bbakerman Makes sense, added a test to |
bbakerman
approved these changes
Dec 21, 2021
Member
|
Thank you for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArgValueOfAllowedTypeChecker#checkArgValueMatchesAllowedScalar()doesn't check the runtime wiring's wiring factory first when fetching scalar implementations, which can lead to it missing them. This PR updates the code to check it.