Skip to content

Simplify some isEqualTo implementations - #2620

Merged
bbakerman merged 1 commit into
graphql-java:masterfrom
dfa1:simplify-isEqualTo
Dec 2, 2021
Merged

bbakerman merged 1 commit into
graphql-java:masterfrom
dfa1:simplify-isEqualTo

Conversation

@dfa1

@dfa1 dfa1 commented Nov 28, 2021

Copy link
Copy Markdown
Contributor

Hi again @andimarek @bbakerman,

another small contribution: isEqualTo implementation was overly complex and hard to read...

In particular:
- use of null-safe Objects.equals
- avoid double negation

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bbakerman bbakerman added this to the 18.0 milestone Dec 2, 2021
@bbakerman
bbakerman merged commit 08b4b01 into graphql-java:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants