Fix integration test using the default Locale in Locale#getDisplayName() #2611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration test was checking if DataFetchingEnvironment#getLocale()#getDisplayName() returned "German" when the locale passed to the ExecutionInput was Locale.GERMAN. This commit changes the call to getDisplayName(Locale.ENGLISH). Making sure the system locale doesn't affect the test.
Member
|
Thanks for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration test was checking if DataFetchingEnvironment#getLocale()#getDisplayName() returned "German" when the locale passed to the ExecutionInput was Locale.GERMAN.
This PR changes the call to getDisplayName(Locale.ENGLISH). Making sure the system locale doesn't affect the test.
My Locale is nl_NL, so the test was comparing
Duits("German" in Dutch) toGerman(in English of course)