Skip to content

Fix integration test using the default Locale in Locale#getDisplayName() - #2611

Merged
bbakerman merged 1 commit into
graphql-java:masterfrom
jord1e:fix-german-integration-test
Nov 15, 2021
Merged

bbakerman merged 1 commit into
graphql-java:masterfrom
jord1e:fix-german-integration-test

Conversation

@jord1e

@jord1e jord1e commented Nov 13, 2021

Copy link
Copy Markdown
Contributor

The integration test was checking if DataFetchingEnvironment#getLocale()#getDisplayName() returned "German" when the locale passed to the ExecutionInput was Locale.GERMAN.

This PR changes the call to getDisplayName(Locale.ENGLISH). Making sure the system locale doesn't affect the test.

My Locale is nl_NL, so the test was comparing Duits ("German" in Dutch) to German (in English of course)

The integration test was checking if DataFetchingEnvironment#getLocale()#getDisplayName() returned "German" when the locale passed to the ExecutionInput was Locale.GERMAN. This commit changes the call to getDisplayName(Locale.ENGLISH). Making sure the system locale doesn't affect the test.
@bbakerman bbakerman added this to the 18.0 milestone Nov 15, 2021
@bbakerman
bbakerman merged commit 4eed7c9 into graphql-java:master Nov 15, 2021
@bbakerman

Copy link
Copy Markdown
Member

Thanks for that

@jord1e
jord1e deleted the fix-german-integration-test branch November 15, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants