Propagate errors to individual Subscription events #2610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compliance with the GraphQL (October 2021) spec section 6.2.3.2 ("Response Stream") under ExecuteSubscriptionEvent point 5.
Fixes graphql-java#2609
jord1e
force-pushed
the
fix-2609-subscriptions
branch
from
0aa3be3 to
f9f45a1
Compare
jord1e
force-pushed
the
fix-2609-subscriptions
branch
from
f9f45a1 to
d1b42fa
Compare
Member
|
Thanks for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR on this project, glad to be able to finally contribute! Please let me know if I should change anything.
This PR fixes #2609.
The same issue may also emerge at line 461 and 476 (I wouldn't know in which situations though). LMK if I should apply the same change there.The PR fixes compliance with the GraphQL (October 2021) spec section 6.2.3.2 ("Response Stream") under ExecuteSubscriptionEvent point 5.