Sort schema directives in SchemaPrinter.
#2575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folone
force-pushed
the
gleontiev/schema-directive-sorting
branch
from
1917049 to
abaa184
Compare
Member
|
See also - #2561 I think we will include this PR first and rebase that other one on top of it. The other PR offers a comre complete sorting mechanism for types as well as type elements (fields / args/ directives) |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello from Twitter!
We have a system that stores the gold schema file, which is generated by the
SchemaPrinter. To avoid having to detect sweeping changes in the schema, we rely on stable alphabetical sorting for all the schema elements – types, fields inside of objects, arms inside of enums, directives, scalars, etc. We've noticed that graphql-java does not sort directive definitions. This patch fixes that.