Skip to content

Improve non-nullable argument exception in ValuesResolver #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bbakerman merged 1 commit into from
Oct 4, 2021
Merged

Improve non-nullable argument exception in ValuesResolver #2572

bbakerman merged 1 commit into from
Oct 4, 2021

Conversation

@dondonz
Copy link
Member

@dondonz dondonz commented Oct 4, 2021

Addresses #2524.

Previously, an non-nullable argument with a coerced null value raised a generic RuntimeException. This PR updates the exception to be more meaningful.

bbakerman
bbakerman approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bbakerman bbakerman added this to the 18.0 milestone Oct 4, 2021
@bbakerman bbakerman merged commit b6611f0 into graphql-java:master Oct 4, 2021
@dondonz dondonz deleted the 2524-better-exception branch October 5, 2021 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbakerman bbakerman bbakerman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dondonz @bbakerman