Fix triple nested enum validation error #2570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/groovy/graphql/execution/ValuesResolverTest.groovy
dondonz
changed the title
dondonz
commented
Oct 5, 2021
| } else { | ||
| Object coercedValue = externalValueToInternalValue(fieldVisibility, variableType, value); | ||
| coercedValues.put(variableName, coercedValue); | ||
| try { |
Member
Author
There was a problem hiding this comment.
The fundamental change is to move the CoercingParseValueException catch one function earlier in the chain, to externalValueToInternalValueForVariables.
Although it appears many lines are changing, it's mostly only indentation for the try catch block.
Member
Author
There was a problem hiding this comment.
The rationale for moving the catch: the source location is available here, whereas it is not passed down to the next function externalValueToInternalValue.
bbakerman
reviewed
Oct 7, 2021
| executionResult.data == null | ||
| executionResult.errors.size() == 1 | ||
| executionResult.errors[0].errorType == ErrorType.ValidationError | ||
| executionResult.errors[0].message == 'Variable \'input\' has an invalid value: Invalid input for Enum \'PositionType\'. No value found for name \'UNKNOWN_POSITION\'' |
Member
There was a problem hiding this comment.
For the record - Groovy has 4 types of comments
' single quotes '
" double quotes "
""" triple double quotes """
''' triple single quotes '''
if you find yourself using `'input' - just swap quotes
bbakerman
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2560 and improves exception messaging for
CoercingParseValueException.invalid error: