Skip to content

A protected method for logging #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
Oct 2, 2021
Merged

A protected method for logging #2569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/main/java/graphql/execution/SimpleDataFetcherExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,20 @@ public DataFetcherExceptionHandlerResult onException(DataFetcherExceptionHandler
ResultPath path = handlerParameters.getPath();

ExceptionWhileDataFetching error = new ExceptionWhileDataFetching(path, exception, sourceLocation);
logNotSafe.warn(error.getMessage(), exception);
logException(error, exception);

return DataFetcherExceptionHandlerResult.newResult().error(error).build();
}

/**
* Called to log the exception - a subclass could choose to something different in logging terms
* @param error the graphql error
* @param exception the exception that happened
*/
protected void logException(ExceptionWhileDataFetching error, Throwable exception) {
logNotSafe.warn(error.getMessage(), exception);
}

/**
* Called to unwrap an exception to a more suitable cause if required.
*
Expand Down