Skip to content

Add InstrumentationValidationParameters to QueryComplexityInfo - #2558

Merged
bbakerman merged 1 commit into
graphql-java:masterfrom
stevenleeDB:add-params-complexity
Oct 2, 2021
Merged

bbakerman merged 1 commit into
graphql-java:masterfrom
stevenleeDB:add-params-complexity

Conversation

@stevenleeDB

Copy link
Copy Markdown
Contributor

Addressing #2547

@bbakerman bbakerman added this to the 18.0 milestone Sep 23, 2021

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

I had a concern that the raw parameters would to "wide" but given that MaxQueryComplexityInstrumentation is an instrumentation anyway, giving access to the validtion parameters is ok

@stevenleeDB

Copy link
Copy Markdown
Contributor Author

@bbakerman thanks! Would you be able to merge this for me?

@bbakerman
bbakerman merged commit 9fb48c5 into graphql-java:master Oct 2, 2021
@softprops

Copy link
Copy Markdown

any word on when the next release will be that would include these changes?

@bbakerman

bbakerman commented Nov 25, 2021 via email

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants