Skip to content

Support for custom validation error - #2528

Merged
bbakerman merged 6 commits into
graphql-java:masterfrom
dugenkui03:support_for_custom_validationError
Oct 4, 2021
Merged

bbakerman merged 6 commits into
graphql-java:masterfrom
dugenkui03:support_for_custom_validationError

Conversation

@dugenkui03

Copy link
Copy Markdown
Contributor

No description provided.

import graphql.PublicApi;

@PublicApi
public interface ValidationErrorTypeInterface {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark interface for validation error type.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to accept this PR - However I would like the name of this to be ValidationErrorClassification (like how we have ErrorClassification

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename to ValidationErrorClassification please

@dugenkui03

Copy link
Copy Markdown
Contributor Author

Can we rename to ValidationErrorClassification please

Thanks for your review, ValidationErrorTypeInterface has been rename to ValidationErrorClassification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants