Skip to content

groups together fields into the one object type during AST compilation - #2501

Merged
bbakerman merged 1 commit into
masterfrom
group_normalised_field_ast_by_object_type_name
Aug 4, 2021
Merged

bbakerman merged 1 commit into
masterfrom
group_normalised_field_ast_by_object_type_name

Conversation

@bbakerman

Copy link
Copy Markdown
Member

Improves the AST compilation for normalised fields - to make it more human ready

@bbakerman bbakerman added this to the 18.0 milestone Aug 4, 2021

@andimarek andimarek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it looks good, but it might worth to reparse the output and compare the NormalizedFields (a kind of roundtrip test) to make sure. This relies here on the human side to check the output.

@bbakerman
bbakerman merged commit dfc3a92 into master Aug 4, 2021
@andimarek andimarek modified the milestones: 18.0, 17.1 Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants