Make TypeDefinitionRegistry serializable#2454
Merged
Merged
Conversation
andimarek
approved these changes
Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow a "parsed" SDL file to be put into an external cache say.
All of the AST nodes are serializable - why not the parsed container of them? Hence this PR.
However in practice is not that much faster than parsing really. So caching the SDL String and reparsing might be in the same ballpark and a String is a simpler contsruct to cache
The benchmark shows that serialization is faster - YMMV
In a low CPU constrained environment, like Serverless, this might be a faster way to pre-compute part of the schema build process.
See #2452