Skip to content

Strict boolean support for Strings in and out #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 1 commit into from
Jul 5, 2021
Merged

Strict boolean support for Strings in and out #2419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/java/graphql/scalar/GraphqlBooleanCoercing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,14 @@ private Boolean convertImpl(Object input) {
if (input instanceof Boolean) {
return (Boolean) input;
} else if (input instanceof String) {
return Boolean.parseBoolean((String) input);
String lStr = ((String) input).toLowerCase();
if (lStr.equals("true")) {
return true;
}
if (lStr.equals("false")) {
return false;
}
return null;
Copy link
Member Author

@bbakerman bbakerman Jul 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null causes a coercing exception ins code you cant see in the diff

} else if (isNumberIsh(input)) {
BigDecimal value;
try {
Expand Down
12 changes: 8 additions & 4 deletions src/test/groovy/graphql/ScalarsBooleanTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ class ScalarsBooleanTest extends Specification {
"false" | false
"true" | true
"True" | true
"some value not true" | false
"" | false
0 | false
1 | true
-1 | true
Expand All @@ -70,8 +68,14 @@ class ScalarsBooleanTest extends Specification {
thrown(CoercingSerializeException)

where:
value | _
new Object() | _
value | _
new Object() | _
"some value not true" | _
"" | _
"T" | _
"t" | _
"F" | _
"f" | _
}

@Unroll
Expand Down