Repository navigation
Allow specification of mutation strategy - #240
Merged
dminkovsky merged 1 commit intoDec 19, 2016
Merged
Conversation
dminkovsky
force-pushed
the
custom-mutation-strategy
branch
from
November 15, 2016 02:43
ead1e93 to
946762a
Compare
Contributor
Author
|
Will add some tests, though this passes currently. |
Contributor
There was a problem hiding this comment.
Nit: I wonder if this should be deprecated with the new change.
Member
There was a problem hiding this comment.
I think the cod should have a Builder of GraphQL objects so it can be extended more easily over time.
GraphQL.newGraph()
.schema(mySchema)
.executionStategy(s1)
.mutationStrategy(ms)
.build();
I have a PR in that adds an "Instrumentation SPI" and this is YET another example adding extra aspects to the GrapQL object
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out @IamCornholio. Going to leave this for now, and consider @bbakerman's builder PR. Thanks
dminkovsky
force-pushed
the
custom-mutation-strategy
branch
from
November 16, 2016 14:51
946762a to
c01d6bf
Compare
dminkovsky
force-pushed
the
custom-mutation-strategy
branch
2 times, most recently
from
December 19, 2016 00:04
5030313 to
d2c5e62
Compare
dminkovsky
force-pushed
the
custom-mutation-strategy
branch
from
December 19, 2016 00:05
d2c5e62 to
421383c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #208 and #97. Use case for me is writing an async execution strategy. A custom mutation strategy is needed to not block on mutation results, even while they are executed serially.