Repository navigation
ExecutionStepInfo optimisations - #2023
Merged
Merged
Conversation
…r of calls to this
Contributor
|
but I look forward to see the cumulative effect of all the optimizations you made :) |
andimarek
approved these changes
Sep 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds lazy ExecutionStepInfo for instrumentation calls )where they MAY not ever use it) and also reduces the number of calls create them and variable resolving.
I ran this code under JProfiler and
graphql.execution.ExecutionStrategy#createExecutionStepInfoshowed up as a hotspot. Looking into it I see it being called a lot but for low value. I suspect some coy and paste happened here.Anyway this is only marginally better performance
There are NO major wins here but it doe less work AND makes the parameters lazy for instrumentation that may never use the parameters.