Skip to content

1897: Fix argument implementation in SchemaValidator - #1926

Merged
andimarek merged 1 commit into
graphql-java:masterfrom
felipe-gdr:1897_fix-argument-implementation-in-schema-validator
May 28, 2020
Merged

andimarek merged 1 commit into
graphql-java:masterfrom
felipe-gdr:1897_fix-argument-implementation-in-schema-validator

Conversation

@felipe-gdr

Copy link
Copy Markdown
Member

I've missed one scenario on the my previous PR (#1920).

Since now we're no longer relying on argument positions to do the validation, it doesn't make sense to compare argument count anymore.

@felipe-gdr

Copy link
Copy Markdown
Member Author

@andimarek it would be nice if we could add this fix to the v15 release.

@andimarek andimarek added this to the 15.0 milestone May 28, 2020
@andimarek
andimarek merged commit 497d2ac into graphql-java:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants