Repository navigation
1897: Fix field argument validation in SchemaValidator - #1920
Merged
andimarek merged 1 commit intoMay 25, 2020
Merged
Conversation
andimarek
reviewed
May 24, 2020
| goodErrorCollector.getErrors().isEmpty() | ||
| } | ||
|
|
||
| def "type can declare extra optional field arguments"() { |
Member
There was a problem hiding this comment.
we should add also an SDL based test, because we are currently not always consistent.
Member
Author
There was a problem hiding this comment.
There are tests that cover that for the SDL already in graphql.schema.idl.SchemaTypeCheckerTest.
"test field arguments on object can contain additional optional arguments"
Currently, the SDL validation doesn't reproduce the error described in the ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing type can declare more field arguments than in the implemented interface given that the extra arguments are optional (aka not non-null).
fixes: #1897