Skip to content

1898 fix field redefinition in extensions - #1899

Closed
felipe-gdr wants to merge 12 commits into
graphql-java:masterfrom
felipe-gdr:1898_fix-field-redefinition-in-extensions
Closed

felipe-gdr wants to merge 12 commits into
graphql-java:masterfrom
felipe-gdr:1898_fix-field-redefinition-in-extensions

Conversation

@felipe-gdr

Copy link
Copy Markdown
Member

Change validation logic so it doesn't allow field redefinition by extensions even if the field types are the same.

This change will make the validation of GraphQL Java more aligned with the validation done by the reference graphql-js implementation.

This should be merged after #1884 is merged.

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the thigns that GitHub does not do well is how to see the diff from a diff. eg how do I see the difference between this and the other PR which I accept

@andimarek andimarek added this to the 15.0 milestone May 19, 2020
- use FpKit
- fix Generic definition in ImplementingTypeDefinition
- don't break public API in TypeDefinitionRegistry
@felipe-gdr

Copy link
Copy Markdown
Member Author

One of the thigns that GitHub does not do well is how to see the diff from a diff. eg how do I see the difference between this and the other PR which I accept

Yeah, it's a horrible experience.
I wish I could target this PR to that other PR that hasn't been merged yet.

@felipe-gdr
felipe-gdr force-pushed the 1898_fix-field-redefinition-in-extensions branch from eab80ac to fae4fe5 Compare May 20, 2020 10:44
@felipe-gdr

Copy link
Copy Markdown
Member Author

I'm closing this PR and opening a new one now that #1884 has been merged

@felipe-gdr felipe-gdr closed this May 24, 2020
@andimarek andimarek removed this from the 15.0 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants