Repository navigation
1898 fix field redefinition in extensions - #1899
Closed
felipe-gdr wants to merge 12 commits into
Closed
felipe-gdr wants to merge 12 commits into
felipe-gdr wants to merge 12 commits into
Conversation
bbakerman
approved these changes
May 19, 2020
bbakerman
left a comment
Member
There was a problem hiding this comment.
One of the thigns that GitHub does not do well is how to see the diff from a diff. eg how do I see the difference between this and the other PR which I accept
- use FpKit - fix Generic definition in ImplementingTypeDefinition - don't break public API in TypeDefinitionRegistry
Member
Author
Yeah, it's a horrible experience. |
felipe-gdr
force-pushed
the
1898_fix-field-redefinition-in-extensions
branch
from
May 20, 2020 10:44
eab80ac to
fae4fe5
Compare
Member
Author
|
I'm closing this PR and opening a new one now that #1884 has been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change validation logic so it doesn't allow field redefinition by extensions even if the field types are the same.
This change will make the validation of GraphQL Java more aligned with the validation done by the reference graphql-js implementation.
This should be merged after #1884 is merged.