Repository navigation
1764 allow interfaces to implement other interfaces #1884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andimarek
merged 22 commits into
graphql-java:master
from
felipe-gdr:1764_allow-interfaces-to-implement-other-interfaces
May 24, 2020
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1b120b2
1764: Interfaces implementing interfaces working with partial validation
felipe-gdr 5dca065
1764: Assert error messages
felipe-gdr ecb52d3
1764: Check if interface is implementing itself
felipe-gdr ea740ef
1764: Fix bug with circular dependency
felipe-gdr 3dfdab1
1764: Use String.join instead of realying on Collection#toString
felipe-gdr ae71b4a
1764: Better test assertions
felipe-gdr 81b1b26
1764: Add tests for transitive implementation declared in interface e…
felipe-gdr 0039150
1764: Simplify implementation of transitive validation
felipe-gdr 465e4a9
1764: Fix transitive implementation declared in extension interface bug
felipe-gdr 4015f0d
1764: Add tests for field and arguments check
felipe-gdr cfe170e
1764: Create integration test
felipe-gdr 04cfbe7
1764: PR feedback
felipe-gdr 39dc3d4
1764: Improve query integration test and add introspection query test
felipe-gdr 7656983
improve tests
andimarek d04a6ec
add Interfaces to GraphQLInterfaceType
andimarek b785a5b
test programmatically GraphQLInterfaceType
andimarek 2792f3a
transitively declaring all interfaces
andimarek 2415050
astprinter handles interfaces in interfaces
andimarek e7a5d84
add schema printer test
andimarek 420481f
1764: Implemente interface implement interface validation in SchemaVa…
felipe-gdr 08d4bb9
add test for interface extensions
andimarek 7601889
Merge branch 'master' into 1764_allow-interfaces-to-implement-other-i…
andimarek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/main/java/graphql/language/ImplementingTypeDefinition.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package graphql.language; | ||
|
|
||
|
|
||
| import graphql.PublicApi; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| /** | ||
| * A {@link TypeDefinition} that might implement interfaces | ||
| * | ||
| * @param <T> | ||
| */ | ||
| @PublicApi | ||
| public interface ImplementingTypeDefinition<T extends TypeDefinition> extends TypeDefinition<T> { | ||
|
|
||
| List<Type> getImplements(); | ||
|
|
||
| List<FieldDefinition> getFieldDefinitions(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package graphql.schema; | ||
|
|
||
| import graphql.PublicApi; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| /** | ||
| * A GraphQLType which can implement interfaces | ||
| */ | ||
| @PublicApi | ||
| public interface GraphQLImplementingType extends GraphQLFieldsContainer { | ||
| /** | ||
| * @return This returns GraphQLInterface or GraphQLTypeReference instances, if the type | ||
| * references are not resolved yet. After they are resolved it contains only GraphQLInterface. | ||
| * Reference resolving happens when a full schema is built. | ||
| */ | ||
| List<GraphQLNamedOutputType> getInterfaces(); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not great name, but not in scope to change it here.