Skip to content

This reduces the memory overhead of NonNullableFieldWasNullException … - #1792

Merged
bbakerman merged 3 commits into
masterfrom
execution-step-info-produces-to-may-strings
May 20, 2020
Merged

bbakerman merged 3 commits into
masterfrom
execution-step-info-produces-to-may-strings

Conversation

@bbakerman

@bbakerman bbakerman commented Feb 17, 2020 •

Copy link
Copy Markdown
Member

This reduces the memory overhead of NonNullableFieldWasNullException and also the ExecutionStepInfo and other places that use parent hierarchies in their .toString

See #1788

This should be back ported to stable I think

…and also the ExecutionStepInfo and other places that use parent hierarchies in their `.toString`
@bbakerman
bbakerman requested a review from andimarek February 17, 2020 10:19
@bbakerman bbakerman added this to the 15.0 milestone Feb 17, 2020
@bbakerman bbakerman added the needs to be backported a bugfix that still needs to be backported label Feb 17, 2020
@bbakerman

Copy link
Copy Markdown
Member Author

Competing PR - #1792

@jhaals jhaals mentioned this pull request Feb 20, 2020
@jhaals

jhaals commented Apr 14, 2020

Copy link
Copy Markdown

Would be great to get this in the next release/backport 🥁

@jhaals

jhaals commented May 14, 2020

Copy link
Copy Markdown

Friendly nudge to @andimarek and @bbakerman. It would be great if you could review this PR.
We are currently running our own internal fork with these patches which has greatly improved performance and GC when NonNullableFieldWasNullException's are thrown.

@bbakerman
bbakerman merged commit 2e391c1 into master May 20, 2020
@bbakerman bbakerman mentioned this pull request May 20, 2020
@andimarek
andimarek deleted the execution-step-info-produces-to-may-strings branch June 5, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs to be backported a bugfix that still needs to be backported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants