Skip to content

Remove toString - #1791

Closed
jhaals wants to merge 1 commit into
graphql-java:masterfrom
jhaals:no-str
Closed

jhaals wants to merge 1 commit into
graphql-java:masterfrom
jhaals:no-str

Conversation

@jhaals

@jhaals jhaals commented Feb 17, 2020

Copy link
Copy Markdown

Removing toString greatly reduces garbage collection times when exceptions are thrown.
This get really expensive when you return list items.
toString is being called by the Throwable class and is not used in the graphql error reporting returned to the caller.

This should improve/fix #1788

Removing toString greatly reduces garbage collection times when exceptions are thrown since toString is called on each field in the query.
This get really expensive when you return list items.
toString is being called by the Throwable class and is not used in graphql error reporting.
@jhaals
jhaals requested a review from bbakerman February 17, 2020 08:22
@jhaals

jhaals commented Feb 20, 2020

Copy link
Copy Markdown
Author

close in favour of #1792

@jhaals jhaals closed this Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Massive GCs with failing upstreams

1 participant