Repository navigation
Remove toString - #1791
Closed
jhaals wants to merge 1 commit into
Closed
Remove toString#1791jhaals wants to merge 1 commit into
jhaals wants to merge 1 commit into
Conversation
Removing toString greatly reduces garbage collection times when exceptions are thrown since toString is called on each field in the query. This get really expensive when you return list items. toString is being called by the Throwable class and is not used in graphql error reporting.
Author
|
close in favour of #1792 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing toString greatly reduces garbage collection times when exceptions are thrown.
This get really expensive when you return list items.
toString is being called by the Throwable class and is not used in the graphql error reporting returned to the caller.
This should improve/fix #1788