Skip to content

Refactor CacheControl - #1492

Merged
bbakerman merged 1 commit into
graphql-java:masterfrom
fcristovao:1490-make-cache-control-code-prettier
Apr 9, 2019
Merged

bbakerman merged 1 commit into
graphql-java:masterfrom
fcristovao:1490-make-cache-control-code-prettier

Conversation

@fcristovao

Copy link
Copy Markdown
Contributor

Refactor that is enabled by #1491.
It's just one extra commit on top of #1491, but I thought it would be easier to do the review in a separate PR

@bbakerman

Copy link
Copy Markdown
Member

I think we will accept this PR as well but it has conflicts

I merged its companion PR so that might be the problem. Can you please fix them up and resubmit after merging master

@fcristovao
fcristovao force-pushed the 1490-make-cache-control-code-prettier branch from b317deb to 40ce584 Compare April 9, 2019 04:09
@fcristovao

Copy link
Copy Markdown
Contributor Author

@bbakerman I've updated the PR with the latest master :)

@bbakerman

Copy link
Copy Markdown
Member

Thanks for this PR and the previous one

@bbakerman
bbakerman merged commit 8bae13f into graphql-java:master Apr 9, 2019
@andimarek andimarek added this to the 13.0 milestone May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants