Skip to content

Fix #1440 ClassCastException when using a fragment with wrong input type condition and overlapping fields are being merged. #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andimarek merged 2 commits into from
Mar 11, 2019
Merged

Fix #1440 ClassCastException when using a fragment with wrong input type condition and overlapping fields are being merged. #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0b561d
Fix #1440 ClassCastException when using a fragment with wrong input t…
tinnou Mar 8, 2019
78d7b15
Fix Enum value for FragmentsOnCompositeType
tinnou Mar 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/graphql/validation/rules/FragmentsOnCompositeType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public void checkFragmentDefinition(FragmentDefinition fragmentDefinition) {
if (type == null) return;
if (!(type instanceof GraphQLCompositeType)) {
String message = "Fragment type condition is invalid, must be on Object/Interface/Union";
addError(ValidationErrorType.InlineFragmentTypeConditionInvalid, fragmentDefinition.getSourceLocation(), message);
addError(ValidationErrorType.FragmentTypeConditionInvalid, fragmentDefinition.getSourceLocation(), message);
}
}
}
4 changes: 2 additions & 2 deletions src/main/java/graphql/validation/rules/OverlappingFieldsCanBeMerged.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,14 +305,14 @@ private void collectFieldsForFragmentSpread(Map<String, List<FieldAndType>> fiel
return;
}
visitedFragmentSpreads.add(fragment.getName());
GraphQLOutputType graphQLType = (GraphQLOutputType) TypeFromAST.getTypeFromAST(getValidationContext().getSchema(),
GraphQLType graphQLType = TypeFromAST.getTypeFromAST(getValidationContext().getSchema(),
fragment.getTypeCondition());
collectFields(fieldMap, fragment.getSelectionSet(), graphQLType, visitedFragmentSpreads);
}

private void collectFieldsForInlineFragment(Map<String, List<FieldAndType>> fieldMap, Set<String> visitedFragmentSpreads, GraphQLType parentType, InlineFragment inlineFragment) {
GraphQLType graphQLType = inlineFragment.getTypeCondition() != null
? (GraphQLOutputType) TypeFromAST.getTypeFromAST(getValidationContext().getSchema(), inlineFragment.getTypeCondition())
? TypeFromAST.getTypeFromAST(getValidationContext().getSchema(), inlineFragment.getTypeCondition())
: parentType;
collectFields(fieldMap, inlineFragment.getSelectionSet(), graphQLType, visitedFragmentSpreads);
}
Expand Down
90 changes: 90 additions & 0 deletions src/test/groovy/graphql/Issue1440.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
package graphql

import graphql.validation.ValidationError
import graphql.validation.ValidationErrorType
import spock.lang.Specification

class Issue1440 extends Specification {

def schema = TestUtil.schema("""
type Query {
nothing: String
}

type Mutation {
updateUDI(input: UDIInput!): UDIOutput
}

type UDIOutput {
device: String
version: String
}

input UDIInput {
device: String
version: String
}
""")

def graphQL = GraphQL.newGraphQL(schema).build()


def "#1440 when fragment type condition is input type it should return validation error - not classCastException"() {
when:
def executionInput = ExecutionInput.newExecutionInput()
.query('''
mutation UpdateUDI($input: UDIInput!) {
updateUDI(input: $input) {
...fragOnInputType
__typename
}
}

# fragment should only target composite types
fragment fragOnInputType on UDIInput {
device
version
__typename
}

''')
.variables([input: [device: 'device', version: 'version'] ])
.build()

def executionResult = graphQL.execute(executionInput)

then:

executionResult.data == null
executionResult.errors.size() == 1
(executionResult.errors[0] as ValidationError).validationErrorType == ValidationErrorType.FragmentTypeConditionInvalid
}

def "#1440 when inline fragment type condition is input type it should return validation error - not classCastException"() {
when:
def executionInput = ExecutionInput.newExecutionInput()
.query('''
mutation UpdateUDI($input: UDIInput!) {
updateUDI(input: $input) {
# fragment should only target composite types
... on UDIInput {
device
version
__typename
}
__typename
}
}
''')
.variables([input: [device: 'device', version: 'version'] ])
.build()

def executionResult = graphQL.execute(executionInput)

then:

executionResult.data == null
executionResult.errors.size() == 1
(executionResult.errors[0] as ValidationError).validationErrorType == ValidationErrorType.InlineFragmentTypeConditionInvalid
}
}
2 changes: 1 addition & 1 deletion src/test/groovy/graphql/validation/rules/FragmentsOnCompositeTypeTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class FragmentsOnCompositeTypeTest extends Specification {
fragmentsOnCompositeType.checkFragmentDefinition(fragmentDefinition)

then:
errorCollector.containsValidationError(ValidationErrorType.InlineFragmentTypeConditionInvalid)
errorCollector.containsValidationError(ValidationErrorType.FragmentTypeConditionInvalid)
}


Expand Down