moves the info if a DF is trivial out of the DF itself into a marker#1309
Merged
Conversation
bbakerman
approved these changes
Nov 8, 2018
bbakerman
reviewed
Nov 8, 2018
| */ | ||
| @PublicApi | ||
| public class PropertyDataFetcher<T> implements DataFetcher<T> { | ||
| public class PropertyDataFetcher<T> implements DataFetcher<T>, TrivialDataFetcher<T> { |
Member
There was a problem hiding this comment.
This can be simply be
public class PropertyDataFetcher<T> implements TrivialDataFetcher<T>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bbakerman this is an alternative to #1300: What do u think?
My main motivation was to keep the info out of the DF interface itself: being the most important Interface we have I think our goal should be to keep it as simple as possible.
The trivial info is not needed in a lot of cased and will distract/confuse especially beginners who look at GraphQL Java the first time more than it helps. IMHO