Adds support for identifying trivial data fetchers and ignoring trivial fields in tracing#1300
Merged
bbakerman merged 3 commits intoNov 5, 2018
Conversation
…al fields in tracing.
bbakerman
commented
Nov 3, 2018
| */ | ||
| default boolean isTrivialDataFetcher() { | ||
| return false; | ||
| } |
Member
Author
There was a problem hiding this comment.
Should this be a default method or a marker interface that some one implements? I like this because subclassing is easier
Member
Author
There was a problem hiding this comment.
Decided to keep current behavior for completeness and allow people to opt into less information if they choose. So default is that trivial fields ARE included by default
bbakerman
commented
Nov 3, 2018
|
|
||
| public static Options newOptions() { | ||
| return new Options(false); | ||
| } |
Member
Author
There was a problem hiding this comment.
What should the default be? include ALL fields by default or exclude trivial fields byy default?
… opt into less information if they choose
andimarek
approved these changes
Nov 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1299