Skip to content

Makes the lib build and tests pass on JDK 11 #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbakerman merged 2 commits into from
Nov 4, 2018
Merged

Makes the lib build and tests pass on JDK 11 #1295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91e332d
Makes the lib build and tests pass on JDK 11
bbakerman Nov 2, 2018
57fbd96
Merge remote-tracking branch 'upstream/master' into make_graphql_buil…
bbakerman Nov 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/groovy/graphql/execution/ExecutorServiceExecutionStrategyTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import java.util.concurrent.TimeUnit
@Deprecated
class ExecutorServiceExecutionStrategyTest extends Specification {

def 'Example usage of ExecutorServiceExecutionStrategy.'() {

@bbakerman bbakerman Nov 3, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

complains as a bad method name

def 'Example usage of ExecutorServiceExecutionStrategy'() {
given:
def query = """
query HeroNameAndFriendsQuery {
Expand Down
13 changes: 6 additions & 7 deletions ...phql/execution/instrumentation/dataloader/PeopleCompaniesAndProductsDataLoaderTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,12 @@ class PeopleCompaniesAndProductsDataLoaderTest extends Specification {
DataFetcher productsDF = new DataFetcher() {
@Override
Object get(DataFetchingEnvironment environment) {
return IntStream.range(0, 5)

@bbakerman bbakerman Nov 3, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some groovy bugs where streams dont work on Java 11 - I am not 100% sure of the reasoning but re-writiing makes it work

.mapToObj(
{ id ->
List<Integer> madeBy = [id * 10001, id * 10002, id * 10003, id * 10004, id * 10005]
new Product(id.toString(), faker.commerce().productName(), id + 200, madeBy)
})
.collect(Collectors.toList())
List<Product> products = new ArrayList<>();
for (int id = 0; id < 5; id++) {
List<Integer> madeBy = [id * 10001, id * 10002, id * 10003, id * 10004, id * 10005]
products.add(new Product(id.toString(), faker.commerce().productName(), id + 200, madeBy))
}
return products
}
}

Expand Down