Makes the lib build and tests pass on JDK 11#1295
Merged
bbakerman merged 2 commits intoNov 4, 2018
Merged
Conversation
bbakerman
requested review from
andimarek,
felipe-gdr,
johnliucn925 and
tsroka
andimarek
requested changes
Nov 3, 2018
andimarek
left a comment
andimarek
left a comment
Member
There was a problem hiding this comment.
the gradle update is not needed anymore
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.5.1-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.8-all.zip |
Member
There was a problem hiding this comment.
gradle is updated now on master
…d_on_java11 # Conflicts: # gradle/wrapper/gradle-wrapper.properties
bbakerman
commented
Nov 3, 2018
| DataFetcher productsDF = new DataFetcher() { | ||
| @Override | ||
| Object get(DataFetchingEnvironment environment) { | ||
| return IntStream.range(0, 5) |
Member
Author
There was a problem hiding this comment.
There is some groovy bugs where streams dont work on Java 11 - I am not 100% sure of the reasoning but re-writiing makes it work
bbakerman
commented
Nov 3, 2018
| @Deprecated | ||
| class ExecutorServiceExecutionStrategyTest extends Specification { | ||
|
|
||
| def 'Example usage of ExecutorServiceExecutionStrategy.'() { |
Member
Author
There was a problem hiding this comment.
complains as a bad method name
andimarek
added
the
not release related
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not fix any specific issues mentioned elsewhere. It just means that the code will run and pass the build on jdk11