Spike: Add a zipper to mutate Ast (WIP) #1148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andimarek
changed the title
bbakerman
reviewed
Aug 5, 2018
| this.children.putAll(Assert.assertNotNull(children)); | ||
| } | ||
|
|
||
| public <T extends Node> List<T> getList(String key) { |
Member
There was a problem hiding this comment.
getChildrenWithName or just getChildren is a better namer I think. You know its a List from the return type
andimarek
added
the
Not to be merged
bbakerman
reviewed
Dec 1, 2018
|
|
||
| //TODO: Implement really in each Node | ||
| @Override | ||
| public ChildrenContainer getNamedChildren() { |
Member
There was a problem hiding this comment.
make it abstract and they will have to!
bbakerman
reviewed
Dec 1, 2018
| @Override | ||
| public T withNewChildren(ChildrenContainer newChildren) { | ||
| return null; | ||
| } |
Member
There was a problem hiding this comment.
again make it abstract eventually to enforce this precondition
bbakerman
reviewed
Dec 1, 2018
| throw new IllegalStateException("children " + key + " is not a single value"); | ||
| } | ||
| return result.size() > 0 ? (T) result.get(0) : null; | ||
| } |
Member
There was a problem hiding this comment.
getChildOrNull might ber a better name
bbakerman
reviewed
Dec 1, 2018
| // // but at which index in the directives list | ||
| // } | ||
| // } | ||
| // } |
Implement Zipper support methods on all concrete Node classes
Member
Author
|
Work will continue here: #1335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.