Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/main/java/graphql/language/Argument.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
@PublicApi
public class Argument extends AbstractNode<Argument> implements NamedNode<Argument> {

private final String name;
private final Value value;
private String name;
private Value value;

@Internal
protected Argument(String name, Value value, SourceLocation sourceLocation, List<Comment> comments) {
Expand Down Expand Up @@ -42,6 +42,14 @@ public Value getValue() {
return value;
}

public void setName(String name) {
this.name = name;
}

public void setValue(Value value) {
this.value = value;
}

@Override
public List<Node> getChildren() {
List<Node> result = new ArrayList<>();
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/graphql/language/ArrayValue.java
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public ArrayValue(List<Value> values) {
}

public List<Value> getValues() {
return new ArrayList<>(values);
return values;
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/graphql/language/Document.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public Document(List<Definition> definitions) {
}

public List<Definition> getDefinitions() {
return new ArrayList<>(definitions);
return definitions;
}


Expand Down
10 changes: 6 additions & 4 deletions src/main/java/graphql/language/EnumValueDefinition.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@


import graphql.Internal;
import graphql.PublicApi;
import graphql.util.TraversalControl;
import graphql.util.TraverserContext;

import java.util.ArrayList;
import java.util.List;
import java.util.function.Consumer;

@PublicApi
public class EnumValueDefinition extends AbstractNode<EnumValueDefinition> implements DirectivesContainer<EnumValueDefinition> {
private final String name;
private final Description description;
Expand All @@ -17,10 +19,10 @@ public class EnumValueDefinition extends AbstractNode<EnumValueDefinition> imple

@Internal
protected EnumValueDefinition(String name,
List<Directive> directives,
Description description,
SourceLocation sourceLocation,
List<Comment> comments) {
List<Directive> directives,
Description description,
SourceLocation sourceLocation,
List<Comment> comments) {
super(sourceLocation, comments);
this.name = name;
this.description = description;
Expand Down
57 changes: 41 additions & 16 deletions src/main/java/graphql/language/Field.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,20 @@
@PublicApi
public class Field extends AbstractNode<Field> implements Selection<Field>, SelectionSetContainer<Field>, DirectivesContainer<Field> {

private final String name;
private final String alias;
private final List<Argument> arguments;
private final List<Directive> directives;
private final SelectionSet selectionSet;
private String name;
private String alias;
private List<Argument> arguments;
private List<Directive> directives;
private SelectionSet selectionSet;

@Internal
protected Field(String name,
String alias,
List<Argument> arguments,
List<Directive> directives,
SelectionSet selectionSet,
SourceLocation sourceLocation,
List<Comment> comments) {
String alias,
List<Argument> arguments,
List<Directive> directives,
SelectionSet selectionSet,
SourceLocation sourceLocation,
List<Comment> comments) {
super(sourceLocation, comments);
this.name = name;
this.alias = alias;
Expand All @@ -49,7 +49,6 @@ public Field(String name) {

/**
* alternative to using a Builder for convenience
*
*/
public Field(String name, List<Argument> arguments) {
this(name, null, arguments, new ArrayList<>(), null, null, new ArrayList<>());
Expand All @@ -74,7 +73,9 @@ public List<Node> getChildren() {
List<Node> result = new ArrayList<>();
result.addAll(arguments);
result.addAll(directives);
if (selectionSet != null) result.add(selectionSet);
if (selectionSet != null) {
result.add(selectionSet);
}
return result;
}

Expand All @@ -89,7 +90,15 @@ public String getAlias() {
}

public List<Argument> getArguments() {
return new ArrayList<>(arguments);
return arguments;
}

public void setArguments(List<Argument> arguments) {
this.arguments = arguments;
}

public void setDirectives(List<Directive> directives) {
this.directives = directives;
}

@Override
Expand All @@ -102,10 +111,26 @@ public SelectionSet getSelectionSet() {
return selectionSet;
}

public void setName(String name) {
this.name = name;
}

public void setAlias(String alias) {
this.alias = alias;
}

public void setSelectionSet(SelectionSet selectionSet) {
this.selectionSet = selectionSet;
}

@Override
public boolean isEqualTo(Node o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass()) {
return false;
}

Field that = (Field) o;

Expand Down
14 changes: 11 additions & 3 deletions src/main/java/graphql/language/FieldDefinition.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

@PublicApi
public class FieldDefinition extends AbstractNode<FieldDefinition> implements DirectivesContainer<FieldDefinition> {
private final String name;
private final Type type;
private String name;
private Type type;
private final Description description;
private final List<InputValueDefinition> inputValueDefinitions;
private final List<Directive> directives;
Expand Down Expand Up @@ -53,7 +53,7 @@ public Description getDescription() {
}

public List<InputValueDefinition> getInputValueDefinitions() {
return new ArrayList<>(inputValueDefinitions);
return inputValueDefinitions;
}

@Override
Expand Down Expand Up @@ -92,6 +92,14 @@ public FieldDefinition deepCopy() {
);
}

public void setName(String name) {
this.name = name;
}

public void setType(Type type) {
this.type = type;
}

@Override
public String toString() {
return "FieldDefinition{" +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public List<Directive> getDirectives() {
}

public List<InputValueDefinition> getInputValueDefinitions() {
return new ArrayList<>(inputValueDefinitions);
return inputValueDefinitions;
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/graphql/language/ObjectTypeDefinition.java
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public List<Directive> getDirectives() {
}

public List<FieldDefinition> getFieldDefinitions() {
return new ArrayList<>(fieldDefinitions);
return fieldDefinitions;
}

@Override
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/graphql/language/OperationDefinition.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ public enum Operation {

private final String name;

private final Operation operation;
private Operation operation;
private final List<VariableDefinition> variableDefinitions;
private final List<Directive> directives;
private final SelectionSet selectionSet;
private SelectionSet selectionSet;

@Internal
protected OperationDefinition(String name,
Expand Down Expand Up @@ -67,13 +67,21 @@ public Operation getOperation() {
}

public List<VariableDefinition> getVariableDefinitions() {
return new ArrayList<>(variableDefinitions);
return variableDefinitions;
}

public List<Directive> getDirectives() {
return new ArrayList<>(directives);
}

public void setOperation(Operation operation) {
this.operation = operation;
}

public void setSelectionSet(SelectionSet selectionSet) {
this.selectionSet = selectionSet;
}

@Override
public SelectionSet getSelectionSet() {
return selectionSet;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/graphql/language/SchemaDefinition.java
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public Directive getDirective(String directiveName) {


public List<OperationTypeDefinition> getOperationTypeDefinitions() {
return new ArrayList<>(operationTypeDefinitions);
return operationTypeDefinitions;
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/graphql/language/SelectionSet.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public SelectionSet(List<Selection> selections) {
}

public List<Selection> getSelections() {
return new ArrayList<>(selections);
return selections;
}


Expand Down