Skip to content

Check for invalid SimpleListConnection list indices on client-provided cursor #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andimarek merged 2 commits into from
May 20, 2017
Merged

Check for invalid SimpleListConnection list indices on client-provided cursor #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c0a138
Check for invalid list indices on client-provided cursor
dalenavi Mar 21, 2016
b638274
fix an errant newline
dalenavi Mar 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/graphql/relay/SimpleListConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ public Object get(DataFetchingEnvironment environment) {
int beforeOffset = getOffsetFromCursor(environment.<String>getArgument("before"), edges.size());
int end = Math.min(beforeOffset, edges.size());

if (begin > end) begin = end;

edges = edges.subList(begin, end);
if (edges.size() == 0) {
return emptyConnection();
Expand Down Expand Up @@ -104,4 +106,4 @@ private String createCursor(int offset) {
}


}
}
31 changes: 31 additions & 0 deletions src/test/groovy/graphql/relay/SimpleListConnectionTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package graphql.relay

import graphql.language.BooleanValue
import graphql.language.FloatValue
import graphql.language.IntValue
import graphql.language.StringValue
import graphql.relay.SimpleListConnection
import graphql.schema.DataFetchingEnvironment
import spock.lang.Specification
import spock.lang.Unroll

class SimpleListConnectionTest extends Specification {
def "invalid list indices handled"() {
given:
def testList = ["a", "b"]
def listConnection = new SimpleListConnection(testList)
def env = new DataFetchingEnvironment(null, ["after":createCursor(3)], null, null, null, null, null);

when:
Object item = listConnection.get(env);

then:
item instanceof graphql.relay.Connection
}

private static final String DUMMY_CURSOR_PREFIX = "simple-cursor";
private String createCursor(int offset) {
String string = graphql.relay.Base64.toBase64(DUMMY_CURSOR_PREFIX + Integer.toString(offset));
return string;
}
}